tests: Make test-managed succeed without libffi #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZoltanFridrich
approved these changes
Mar 22, 2023
The test_max_session_load test was assuming that the closure assignment would succeed even if the fixed closures are exhausted, thanks to the fallback mechanism when libffi is enabled. This conditionalizes the test with WITH_FFI and do not exceed the limit if libffi is enabled. Signed-off-by: Daiki Ueno <ueno@gnu.org>
ueno
force-pushed
the
wip/dueno/test-managed
branch
from
f0a11ef to
53d07ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test_max_session_load test was assuming that the closure assignment would succeed even if the fixed closures are exhausted, thanks to the fallback mechanism when libffi is enabled. This conditionalizes the test with WITH_FFI and do not exceed the limit if libffi is not enabled.
Fixes: #466