libffi: Fix handling of pulCount parameter of C_GetInterfaceList #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZoltanFridrich
approved these changes
May 9, 2023
There was a problem hiding this comment.
From the specification:
If pInterfaceList is NULL_PTR, then all that C_GetInterfaceList does is return (in *pulCount) the number of interfaces, without actually returning a list of interfaces. The contents of *pulCount on entry to C_GetInterfaceList has no meaning in this case, and the call returns the value CKR_OK.
Makes sense. Changes look good.
When C_GetInterfaceList is called with NULL pInterfaceList, It doesn't make any sense to check the content of pulCount. Signed-off-by: Daiki Ueno <ueno@gnu.org>
ueno
force-pushed
the
wip/dueno/libffi-fixes
branch
from
a4b60b3 to
990bd5a
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
C_GetInterfaceListis called with NULLpInterfaceList, It doesn't make any sense to check the content ofpulCount.Fixes: #495