-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
export-object: Recover public key from algorithm specific attributes #568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ueno
force-pushed
the
wip/dueno/pubkey
branch
2 times, most recently
from
September 21, 2023 12:15
e4567cf
to
746ee29
Compare
ueno
force-pushed
the
wip/dueno/pubkey
branch
10 times, most recently
from
September 22, 2023 03:09
56a937c
to
f993b82
Compare
ueno
force-pushed
the
wip/dueno/pubkey
branch
2 times, most recently
from
September 22, 2023 06:34
9932011
to
590b4af
Compare
Signed-off-by: Daiki Ueno <ueno@gnu.org>
ueno
force-pushed
the
wip/dueno/pubkey
branch
from
September 22, 2023 07:12
590b4af
to
6a28b99
Compare
ZoltanFridrich
requested changes
Sep 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found some small things, other then that looks good.
I have tested the command manually together with valgrind. Seems to work fine. |
ueno
force-pushed
the
wip/dueno/pubkey
branch
7 times, most recently
from
September 26, 2023 08:33
0e56e90
to
3cb5371
Compare
ueno
force-pushed
the
wip/dueno/pubkey
branch
from
September 26, 2023 08:36
3cb5371
to
d0270a7
Compare
ZoltanFridrich
approved these changes
Sep 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Some tokens such as SoftHSMv2 omits CKA_PUBLIC_KEY_INFO when it can be derived from algorithm specific attributes, such as CKA_MODULUS and CKA_PUBLIC_EXPONENT for RSA. This adds support for it if libtasn1 is available at compile time. Signed-off-by: Daiki Ueno <ueno@gnu.org>
ueno
force-pushed
the
wip/dueno/pubkey
branch
from
September 26, 2023 09:29
d0270a7
to
652c115
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tokens such as SoftHSMv2 omit CKA_PUBLIC_KEY_INFO when it can be derived from algorithm specific attributes, such as CKA_MODULUS and CKA_PUBLIC_EXPONENT for RSA. This adds support for it if libtasn1 is available at compile time.
Fixes: #555