Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for p11-kit profile commands #580

Merged
merged 3 commits into from
Oct 3, 2023
Merged

Add tests for p11-kit profile commands #580

merged 3 commits into from
Oct 3, 2023

Conversation

ZoltanFridrich
Copy link
Contributor

@ZoltanFridrich ZoltanFridrich commented Sep 25, 2023 •
edited
Loading

  • added module that is able to load objects from and store result in a .p11-kit file
  • moved persist.c into common
  • added actually useful tests for profile commands

Closes #548

@ZoltanFridrich ZoltanFridrich self-assigned this Sep 25, 2023
@coveralls
Copy link

coveralls commented Sep 25, 2023 •
edited
Loading

Coverage Status

coverage: 69.248% (+0.2%) from 69.021% when pulling 4774e5d on ZoltanFridrich:zfridric_devel4 into f7a89e5 on p11-glue:master.

@ZoltanFridrich ZoltanFridrich force-pushed the zfridric_devel4 branch 4 times, most recently from 026e983 to d6c07a2 Compare September 27, 2023 08:57
github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 27, 2023
View reviewed changes
@ZoltanFridrich ZoltanFridrich force-pushed the zfridric_devel4 branch 4 times, most recently from 31541a6 to 8784a3f Compare October 2, 2023 12:41
ueno
ueno reviewed Oct 2, 2023
View reviewed changes
Copy link
Member

@ueno ueno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe good to test without libtasn1-devel installed; I see a couple of test failures.

@ZoltanFridrich ZoltanFridrich force-pushed the zfridric_devel4 branch 11 times, most recently from 946ea59 to 4774e5d Compare October 3, 2023 09:31
@ZoltanFridrich ZoltanFridrich requested a review from ueno October 3, 2023 09:44
ueno
ueno approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@ueno ueno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@ZoltanFridrich
Move persist files to Common subdirectory
980f2fd 
Signed-off-by: Zoltan Fridrich <zfridric@redhat.com>
@ZoltanFridrich
Add tests for p11-kit profile commands
646afce 
Signed-off-by: Zoltan Fridrich <zfridric@redhat.com>
@ZoltanFridrich
Add CI test for building without ASN.1
6a83b5a 
Signed-off-by: Zoltan Fridrich <zfridric@redhat.com>
@ZoltanFridrich ZoltanFridrich merged commit aedbab2 into p11-glue:master Oct 3, 2023
@ZoltanFridrich ZoltanFridrich added this to the 0.25.1 milestone Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ueno ueno ueno approved these changes

Assignees

@ZoltanFridrich ZoltanFridrich

Labels
category: tests
Projects
None yet
Milestone
0.25.1
Development

Successfully merging this pull request may close these issues.

Add tests for p11-kit add-profile, delete-profile, and delete-object commands
3 participants
@ZoltanFridrich @coveralls @ueno