Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trust: Respect anyExtendedKeyUsage in CA certificates #99

Merged
merged 1 commit into from
Oct 2, 2017

Conversation

ueno
Copy link
Member

@ueno ueno commented Aug 22, 2017

A CA certificate can include anyExtendedKeyUsage (2.5.29.37.0) in the extended key usage extension, if the CA doesn't want to restrict usages of the key. However, previously the trust module treated it as a custom key purpose and failed to match if the search criteria included a key purpose.

@ueno ueno added this to the 0.23.9 milestone Aug 22, 2017
@ueno ueno requested a review from kaie September 26, 2017 20:21
@ueno ueno force-pushed the wip/dueno/enumerate-any branch from cdc4469 to f477f22 Compare October 2, 2017 08:08
@ueno
Copy link
Member Author

ueno commented Oct 2, 2017

Updated commit reflecting comments from @kaie:

  • remove unnecessary critical check
  • add comment on the encoded value in the test

@ueno ueno merged commit 00b829d into p11-glue:master Oct 2, 2017
@ueno ueno deleted the wip/dueno/enumerate-any branch January 17, 2018 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant