fixed issue with wrong state-machine after pull down gesture on presented SFSafariViewController #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ossus-lib
approved these changes
Feb 21, 2024
jozefizso
referenced
this pull request
in slidoapp/oauth2-swift
Oct 21, 2024
…ain branch * upstream/main: Fix visionOS build, bump to 5.3.5 Update version info Implement device grant flow (#416) fixed issue with wrong state-machine after pull down gesture on presented SFSafariViewController (#415) Implement optional custom User-Agent string for embedded MacOS mode (#395) Update project files for Swift 5.3 (#413) Bring ASWebAuthenticationSession to macOS Add deprecation notices for embedded auth. Bump to 5.3.3 Project Maintenance Fix memory issue when dismissing Safari View Controller (#380) Update the Alamofire link to the recent version (#382) Update OAuth2Authorizer+iOS.swift (#402) Add visionOS support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case the SFSafariViewController is presented modally, it can be dismissed via pull down gesture. In that case the state machine is completely broken. Therefore I added the presentationDelegate, which ensures that the same logic is triggered as in case the "Finished" button is pressed with this interaction.