Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Fill gaps with copies' doesn't extend to start or end of scene frame range #33

Closed
Hammers69 opened this issue Nov 5, 2022 · 1 comment · Fixed by #38
Closed

'Fill gaps with copies' doesn't extend to start or end of scene frame range #33

Hammers69 opened this issue Nov 5, 2022 · 1 comment · Fixed by #38
Labels
enhancement New feature or request

Comments

@Hammers69
Copy link

Hammers69 commented Nov 5, 2022

Hi p2or,
I've been doing more testing to figure out the issues I was having and whether I need to report anything. But in the meantime I thought I'd post a couple of things I've discovered. This first one I hope is a fairly simple bug fix.

As the title suggests, 'Fill gaps with copies' in the encode panel only fills frames between the min and max existing frames. It would be great, and I think expected, that the function would fill to the start and end of the scene frame range, since typically it's important to keep shot frame ranges consistent through layout, previs, to editing and final render, say.

I've attached a basic scene file which renders on frames 2 and 8, with a scene frame range of 1-10. After rendering with 'Render Selected Keyframes' the FGwC function fills in frames 3-7, but not 1, 9 or 10.

Many thanks!
Stephen.

FillSeqTest.zip

@p2or p2or added the enhancement New feature or request label Nov 6, 2022
@p2or
Copy link
Owner

p2or commented Nov 22, 2022

Hi @Hammers69,

good news, I think I got it all working. As of the latest commit, the frame range of the scene is taken into account by default. Also when rendered using Loom the 'sequence path' will be set to properly if you click the 'Auto Paths' button.

Please download Loom from here and report back. I hope this will save you some time.

Cheers,
Christian

@p2or p2or mentioned this issue Nov 26, 2022
@p2or p2or closed this as completed in #38 Nov 26, 2022
p2or added a commit that referenced this issue Nov 26, 2022
Scene frame range, resolves #33, #34, #35
p2or added a commit that referenced this issue Dec 15, 2022
Allow to fill the gaps of the given sequence and also copy the frames within the frame range of the scene when the operator is called for the second time
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants