Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that CustomMessageHandler impl is tested #132

Open
luckysori opened this issue Jul 27, 2023 · 0 comments
Open

Ensure that CustomMessageHandler impl is tested #132

luckysori opened this issue Jul 27, 2023 · 0 comments
Labels
ln

Comments

@luckysori
Copy link
Collaborator

luckysori commented Jul 27, 2023 •
edited
Loading

With #128 we introduced changes to the messages sent between the two parties involved in creating LN-DLC channels (probably for vanilla DLC channels too?). The tests in ln_dlc_channel_execution_tests.rs passed, but using the library revealed that we had not updated the CustomMessageHandler implementation to ensure that LDK would be able to forward the new custom message to us. For this reason we had to open #131.

Originally posted by @Tibo-lg in #131 (review)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ln
Projects
LN-DLC
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
1 participant
@luckysori