Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle new Revoke message in CustomMessageHandler impl #131

Merged
merged 1 commit into from
Jul 27, 2023
Merged

Handle new Revoke message in CustomMessageHandler impl #131

merged 1 commit into from
Jul 27, 2023

Conversation

luckysori
Copy link
Collaborator

I was surprised to see that this wasn't caught by the tests 😮 We only discovered this when upgrading the rust-dlc dependency for the 10101 repo.

@luckysori luckysori added the ln label Jul 27, 2023
@luckysori luckysori requested a review from Tibo-lg July 27, 2023 04:30
@luckysori luckysori self-assigned this Jul 27, 2023
Tibo-lg
Tibo-lg approved these changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@Tibo-lg Tibo-lg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah unfortunately the tests don't cover that... it's definitely an issue as it's not the first time that it happens unfortunately.

@luckysori luckysori mentioned this pull request Jul 27, 2023
Open
@luckysori luckysori merged commit 049388b into feature/ln-dlc-channels Jul 27, 2023
166 checks passed
@luckysori luckysori deleted the fix/handle-revoke-msg branch July 27, 2023 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tibo-lg Tibo-lg Tibo-lg approved these changes

Assignees

@luckysori luckysori

Labels
ln
Projects
LN-DLC
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luckysori @Tibo-lg