-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/periodic check returns affected contracts #121
base: fix/fee-comtputation-issue
Are you sure you want to change the base?
Feat/periodic check returns affected contracts #121
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Concept ack. Just feel like it could be made more simple with a boolean instead of an option. Also unsure what are the changes to the cargo files.
dlc-manager/src/manager.rs
Outdated
fn check_signed_contract( | ||
&mut self, | ||
contract: &SignedContract, | ||
) -> Result<Option<ContractId>, Error> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It feels like it'd be easier to just return a boolean here, indicating whether the contract was updated or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
smart!!!
dlc-manager/src/manager.rs
Outdated
@@ -2267,4 +2293,29 @@ mod test { | |||
.on_dlc_message(&offer_message, pubkey()) | |||
.expect_err("To reject the second offer message"); | |||
} | |||
|
|||
#[test] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's not a great test, I think it'd be better to add some checks in the integrations tests.
2cd5f98
to
e9cf8e8
Compare
No description provided.