Feature/ln dlc channels #97
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tibo-lg
force-pushed
the
feature/ln-dlc-channels
branch
5 times, most recently
from
b467ed8 to
b3d3173
Compare
bors bot
added a commit
to get10101/10101
that referenced
this pull request
Mar 7, 2023
213: Update to latest `rust-dlc` r=luckysori a=luckysori The new `rust-dlc` [branch](p2pderivatives/rust-dlc#97) is still WIP, but it's good to keep this dependency up-to-date as much as possible. Co-authored-by: Lucas Soriano del Pino <lucas_soriano@fastmail.com>
Tibo-lg
force-pushed
the
feature/ln-dlc-channels
branch
4 times, most recently
from
15766af to
6cfac30
Compare
Tibo-lg
force-pushed
the
feature/ln-dlc-channels
branch
from
6cfac30 to
182442b
Compare
bors bot
added a commit
to get10101/10101
that referenced
this pull request
Mar 23, 2023
319: fix: Compute payout is greater than total collateral r=luckysori a=holzeis Resolves #289. Resolves #306. The `rust-dlc` [branch](p2pderivatives/rust-dlc#97) that we depend on has already been rebased onto `master`, so we can fix the bug like this. Co-authored-by: Lucas Soriano del Pino <lucas_soriano@fastmail.com>
bors bot
added a commit
to get10101/10101
that referenced
this pull request
Mar 23, 2023
319: fix: Compute payout is greater than total collateral r=luckysori a=holzeis Resolves #289. Resolves #306. The `rust-dlc` [branch](p2pderivatives/rust-dlc#97) that we depend on has already been rebased onto `master`, so we can fix the bug like this. Co-authored-by: Lucas Soriano del Pino <lucas_soriano@fastmail.com>
Tibo-lg
force-pushed
the
feature/ln-dlc-channels
branch
2 times, most recently
from
1743c54 to
89f36af
Compare
bors bot
added a commit
to get10101/10101
that referenced
this pull request
Mar 27, 2023
319: fix: Compute payout is greater than total collateral r=luckysori a=holzeis Resolves #289. Resolves #306. The `rust-dlc` [branch](p2pderivatives/rust-dlc#97) that we depend on has already been rebased onto `master`, so we can fix the bug like this. Co-authored-by: Lucas Soriano del Pino <lucas_soriano@fastmail.com>
Tibo-lg
force-pushed
the
feature/ln-dlc-channels
branch
from
424e623 to
293b26d
Compare
…-auto-closing Feature/ln dlc/handle ldk auto closing
Fix `rust-bitcoin-coin-selection`
BREAKING CHANGE: The implementations of `Writeable` and `Readable` for `ChainMonitor` have changed. We were never reading this list, so keeping it seems unnecessary.
BREAKING CHANGE: Consumers have to call `periodic_chain_monitor` periodically so that `dlc_manager::Manager` and `SubChannelManager` can learn about transactions being confirmed. Furthermore, the `Writeable` and `Readable` traits of `ChainMonitor` have changed, so we are incompatible with `ChainMonitor`s persisted before this patch. There are two consumers of the `ChainMonitor` API: `dlc_manager::Manager` and `SubChannelManager`. Both of them are interested in knowing when certain transactions reach a confirmation target (for now a single confirmation). Before this patch, the only way to learn about confirmed transactions was to call `process_block`. When using both managers (when using LN-DLC channels) this presented two options: 1. Let each manager provide their own block. 2. Have the `SubChannelManager` process the block throught the `ChainMonitor` and reuse the same result to let the `dlc_manager::Manager` process it. The first option led to bugs fixed in 4636ad7. The second option was what was implemented before this patch and it resulted in coupling between the two managers. With this patch we now separate the processing of new blocks from the managers learning about confirmed transactions. This does mean that library consumers will have to periodically call `periodic_chain_monitor` to update the state of `ChainMonitor`. It's less convenient, but it's not different from similar projects such as `rust-lightning`.
By setting this we can avoid the following warning when building: ``` warning: some crates are on edition 2021 which defaults to `resolver = "2"`, but virtual workspaces default to `resolver = "1"` ```
So that it can be compiled in isolation from the rest of the workspace.
…ng-from-confirming Split block processing from confirmation reporting
…sconnect Fix/ln dlc/renew after disconnect
Update to LDK v0.0.116
Use commit tx number to reject stale messages.
Co-authored-by: Mariusz Klochowicz <mariusz@klochowicz.com>
…annel-force-closure
It is possible that a payout curve decreases with the amount of payout as the events increase. This lead to an overflow panic in the evaluate function Signed-off-by: Philipp Hoenisch <philipp@coblox.tech>
…tcurve fix: overflow bug in payout curve
Otherwise we forget about all the registered transactions on restart, which can lead to loss of funds.
Load ChainMonitor in (DLC) Manager constructor if possible
…hannel-keys-id Update rust-lightning dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.