Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #5
Summary
1.) The switch case statement on
SAR_DATA_ENTITY_INPUT_SLOT
has a fall-through here:mdp/src/demo.c
Lines 155 to 158 in 4a580f6
but this case is missing in
_sar_data_free
:mdp/src/demo.c
Lines 30 to 37 in 4a580f6
2.) Missing call to
closedir
afteropendir
:mdp/src/main.c
Lines 301 to 325 in 4a580f6
3.)
strdup
allocated header fields are not freed:mdp/src/demo.c
Lines 546 to 550 in 4a580f6
mdp/src/demo.c
Lines 84 to 91 in 4a580f6