Toggle should use output register, not pin state #55
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion in MarlinFirmware/Marlin#27341.
Function
pin_type::toggle()
reads a value fromgpio_reg().reg_control
(known asFIOPIN
in the LPC1768 manual chapter 9), modifies it and then writes it back togpio_reg().reg_control
. On writing, this updates the output register for GPIO. However the value read actually reads the pin state, not the output register.It is possible when toggling pins in quick succession for a race condition to exist where a pin's output state is still reading an old value when
gpio_reg().reg_control
is read, resulting in lost pin changes.To read the output register, one must read
gpio_reg().reg_set
(FIOSET
in the LPC1768 manual).I am not able to test this PR because I do not have an LPC1768 board but I have a report from MarlinFirmware/Marlin#27341 that it works.