Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: api add user not work when use websocket #351

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix: api add user not work when use websocket #351

wants to merge 2 commits into from
+19 −15

Conversation

fregie
Copy link
Contributor

@fregie fregie commented May 30, 2021

@fregie fregie mentioned this pull request May 30, 2021
Merged
@fregie
Copy link
Contributor Author

fregie commented Jun 7, 2021

Can we merge this?
This bug really affected me.
@p4gefau1t @Loyalsoldier

@ghost
Copy link

ghost commented Jun 7, 2021

@fregie in the sample api after adding a user, the server did not close the stream in time idk of its bug

@fregie
Copy link
Contributor Author

fregie commented Jun 7, 2021

@fregie in the sample api after adding a user, the server did not close the stream in time idk of its bug

yes,you need to close it by cancel the context.

@fregie fregie mentioned this pull request Jun 10, 2021
Open
@aztecrabbit
Copy link

Hi, can i know why this pull request is not merged yet? Is this because the test case failed, or something?

@Loyalsoldier @p4gefau1t @fregie

@fregie
Copy link
Contributor Author

fregie commented Oct 25, 2021

@aztecrabbit
The author has forgoten this repo.
You can use fixed version by my fork.
https://github.com/fregie/trojan-go/tree/latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@p4gefau1t p4gefau1t

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@fregie @aztecrabbit @p4gefau1t