Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does multicast replication preserve local metadata in v1model/simple switch? #1206

Closed
smolkaj opened this issue Aug 3, 2023 · 7 comments · Fixed by #1236
Closed

Does multicast replication preserve local metadata in v1model/simple switch? #1206

smolkaj opened this issue Aug 3, 2023 · 7 comments · Fixed by #1236

Comments

@smolkaj
Copy link
Member

smolkaj commented Aug 3, 2023

Empirically speaking, the answer is yes, on BMv2. However I don't see this documented anywhere currently.
Maybe @jafingerhut would know?

@zhenk14 for visibility.

@jafingerhut
Copy link
Contributor

As far as I know, multicast and unicast are equivalent in the v1model implementation for metadata that is preserved from ingress to egress.

Note: In case you have not heard me say it before, unless the P4_14 specification says something explicitly (and on many such detailed questions like this, it is often silent on the topic), I consider the behavioral-model implementation of v1model to be the effective definition of the v1model architecture. Yes, occasionally we have changed things in this implementation because it seems wrong, but not many such things have been changed since behavioral-model was written.

@smolkaj
Copy link
Member Author

smolkaj commented Aug 4, 2023

Treating unicast & multicast uniformly makes sense.

Treating BMv2 as the definition also makes sense at this point, given that the P4_14 spec is very incomplete. A search for "multicast" in the spec surfaces nearly no information at all.

@jafingerhut
Copy link
Contributor

If you have any suggested PR for this documentation file that would help clarify the BMv2 v1model behavior here, I'd be happy to review it: https://github.com/p4lang/behavioral-model/blob/main/docs/simple_switch.md

@smolkaj
Copy link
Member Author

smolkaj commented Aug 21, 2023

Will send a PR after https://github.com/p4lang/behavioral-model/pull/1204/files goes in to avoid merge conflicts.

@jafingerhut
Copy link
Contributor

Sorry for the long delay. I just approved and merged PR #1204

Copy link

github-actions bot commented Mar 5, 2024

This issue is stale because it has been open 180 days with no activity. Remove stale label or comment, or this will be closed in 180 days

@smolkaj
Copy link
Member Author

smolkaj commented Mar 5, 2024

Reminder to myself: need to send a PR to clarify this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants