Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add more CRC tests #1235

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

test: Add more CRC tests #1235

wants to merge 3 commits into from

Conversation

vlstill
Copy link

@vlstill vlstill commented Mar 18, 2024

No description provided.

@jafingerhut
Copy link
Contributor

Is this something that you and fruffy decided should be in the p4c repo, or should be in this one?

If this one, note that I don't think anyone considers BMv2 "their project" to review PRs for. Antonin Bas did for many years, but it has also been many years since it was his job (at least 5 years, maybe longer), so I don't think it is right to expect him to continue maintaining it.

@vlstill
Copy link
Author

vlstill commented Mar 20, 2024

Is this something that you and fruffy decided should be in the p4c repo, or should be in this one?

If this one, note that I don't think anyone considers BMv2 "their project" to review PRs for. Antonin Bas did for many years, but it has also been many years since it was his job (at least 5 years, maybe longer), so I don't think it is right to expect him to continue maintaining it.

Hi! Fabian suggested I take the BMv2 hash tests and add them to the tests in my PR p4lang/p4c#4526, but I misunderstood and did it the other way :-D. But considering there are less tests in BMv2 it would make sense to have them here too.

That said, I need to find out what is failing in the build. I don't have it working locally yet, I plan to give it some time and if I can get it to work in reasonable time I will ask around for reviews.

@jafingerhut
Copy link
Contributor

If you are using one of the operating systems my scripts support (a few recent versions of Ubuntu or Fedora Linux), they can install behavioral-model and p4c from source, and whatever dependencies they need: https://github.com/jafingerhut/p4-guide/blob/master/bin/README-install-troubleshooting.md#quick-instructions-for-successful-install-script-run

Copy link

This PR is stale because it has been open 180 days with no activity. Remove stale label or comment, or this will be closed in 180 days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants