Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document command-line options for simple_switch_grpc #833

Merged
merged 1 commit into from
Dec 12, 2019
Merged

Document command-line options for simple_switch_grpc #833

merged 1 commit into from
Dec 12, 2019

Conversation

antoninbas
Copy link
Member

Fixes #831

@codecov-io
Copy link

codecov-io commented Dec 11, 2019 •
edited
Loading

Codecov Report

Merging #833 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #833      +/-   ##
==========================================
+ Coverage   74.76%   74.77%   +<.01%     
==========================================
  Files         115      115              
  Lines       10193    10193              
==========================================
+ Hits         7621     7622       +1     
+ Misses       2572     2571       -1
Impacted Files Coverage Δ
src/bm_sim/target_parser.cpp 74.64% <ø> (ø) ⬆️
src/bm_sim/learning.cpp 82.06% <0%> (+0.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16c6999...2cc8959. Read the comment docs.

jafingerhut
jafingerhut approved these changes Dec 11, 2019
View reviewed changes
Copy link
Contributor

@jafingerhut jafingerhut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for the on minor nitpick question I added as a comment, it all looks good to me. Thanks!

@antoninbas antoninbas force-pushed the antonin/simple-switch-grpc-document-command-line-options branch from b88f57f to f30c853 Compare December 11, 2019 20:17
@antoninbas antoninbas force-pushed the antonin/simple-switch-grpc-document-command-line-options branch from f30c853 to 2cc8959 Compare December 11, 2019 20:24
@antoninbas antoninbas merged commit 9ef3248 into master Dec 12, 2019
@antoninbas antoninbas deleted the antonin/simple-switch-grpc-document-command-line-options branch December 12, 2019 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jafingerhut jafingerhut jafingerhut approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Is there a simple_switch_grpc switch port for P4Runtime PacketIn/PacketOut ?
3 participants
@antoninbas @codecov-io @jafingerhut