Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 80: Fix incorrect handling of the missing manifest file #81

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

vgurevich
Copy link
Contributor

Fixed the code that handles the case of missing manifest file as described in issue #80

Fixed the code that handles the case of missing manifest file as described in issue #80 

Signed-off-by: Vladimir Gurevich <vag@p4ica.com>
Copy link
Contributor

@jafingerhut jafingerhut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not tested it myself, but the reasoning behind the exception raised without this fix in the linked issue, and this change, look correct to me.

@jafingerhut jafingerhut merged commit 1f97778 into main Feb 26, 2025
3 checks passed
@jafingerhut jafingerhut deleted the vgurevich/issue-80 branch February 26, 2025 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants