Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v1.2.5 #1313

Merged
merged 4 commits into from
Oct 11, 2024
Merged

Release v1.2.5 #1313

merged 4 commits into from
Oct 11, 2024

Conversation

jonathan-dilorenzo
Copy link
Collaborator

@jonathan-dilorenzo jonathan-dilorenzo commented Oct 10, 2024

Also updated changelog and added a new section for the next release.

@jonathan-dilorenzo jonathan-dilorenzo self-assigned this Oct 10, 2024
Signed-off-by: Jonathan DiLorenzo <dilo@google.com>
Signed-off-by: Jonathan DiLorenzo <dilo@google.com>
Signed-off-by: Jonathan DiLorenzo <dilo@google.com>
- Warnings for unknown annotations.

# Appendix: Revision History { #sec-revision-history; @h1:"A" }

## Summary of changes made in version 1.2.4
## Summary of changes made in unreleased version
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the intention of this section?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea will be for PRs that make changes to already add bullet for what they changed. Then, ideally, cutting a new release will be as easy as changing "unreleased version" to "version X.Y.Z"

@jonathan-dilorenzo
Copy link
Collaborator Author

@jafingerhut and @jnfoster, since neither Ryan or I have done this before, I'd like approval from you too before merging (though I'll update the date I say it's released to the date we actually do the release once I've got the approvals).

Copy link
Collaborator

@jafingerhut jafingerhut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Signed-off-by: Jonathan DiLorenzo <dilo@google.com>
@jonathan-dilorenzo jonathan-dilorenzo merged commit f0e1a24 into main Oct 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants