-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add @pure and @noSideEffects annotations on extern functions/methods #835
Add @pure and @noSideEffects annotations on extern functions/methods #835
Conversation
This is a subset of the changes in #802. It includes only the additions of the I did add one phrase to qualify the example of a |
Since creating this PR, I have made a few more changes to the proposed text. I may have gone overboard with too many words, so please read it and see if my edited version looks reasonable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you should add a changelog too.
Is the next version number 1.2.1? 1.3.0? Something else? The latest version number mentioned in the revision history right now is 1.2.0, released late 2019. |
We may need to add more stuff there. |
Beginnings of a revision history for the next release added. I did not attempt to add all of them, only the one in this PR. |
I think we agreed to merge these changes in the spec. |
No description provided.