Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @pure and @noSideEffects annotations on extern functions/methods #835

Merged

Conversation

jafingerhut
Copy link
Collaborator

No description provided.

@jafingerhut
Copy link
Collaborator Author

jafingerhut commented Apr 9, 2020

This is a subset of the changes in #802. It includes only the additions of the @pure and @noSideEffects annotations.

I did add one phrase to qualify the example of a hash function that would be legal to have a @pure annotation -- a hash function that had control-plane writable seed/initialization-vector value should not be annotated @pure.

@jafingerhut
Copy link
Collaborator Author

Since creating this PR, I have made a few more changes to the proposed text. I may have gone overboard with too many words, so please read it and see if my edited version looks reasonable.

Copy link
Contributor

@mihaibudiu mihaibudiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should add a changelog too.

@jafingerhut
Copy link
Collaborator Author

Is the next version number 1.2.1? 1.3.0? Something else? The latest version number mentioned in the revision history right now is 1.2.0, released late 2019.

@mihaibudiu
Copy link
Contributor

We may need to add more stuff there.
Use 1.2.1 and we can fix this later.

@jafingerhut
Copy link
Collaborator Author

Beginnings of a revision history for the next release added. I did not attempt to add all of them, only the one in this PR.

@mihaibudiu
Copy link
Contributor

I think we agreed to merge these changes in the spec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants