Allow --Wdisable to take precedence over --Werror for warning messages

Signed-off-by: Kyle Cripps <kyle@pensando.io>
p4lang · Sep 3, 2024 · dbd20a5 · dbd20a5
1 parent 3306162
commit dbd20a5
Showing 1 changed file with 0 additions and 2 deletions.
diff --git a/lib/error_reporter.h b/lib/error_reporter.h
@@ -226,8 +226,6 @@ class ErrorReporter {
     /// @return the action to take for the given diagnostic, falling back to the
     /// default action if it wasn't overridden via the command line or a pragma.
     DiagnosticAction getDiagnosticAction(cstring diagnostic, DiagnosticAction defaultAction) {
-        // Actions for errors can never be overridden.
-        if (defaultAction == DiagnosticAction::Error) return defaultAction;
         auto it = diagnosticActions.find(diagnostic);
         if (it != diagnosticActions.end()) return it->second;
         // if we're dealing with warnings and they have been globally modified