compiler bug: cloning

[smolkaj]

The program below compiles fine with the p4c-bm2-ss backend, put crashes with

Invalid number of parameters for primitive action clone_ingress_pkt_to_egress: expected 2 but got 1

when executed with the simple_switch bmv2:

#include <core.p4>
#include <v1model.p4>

struct H { };
struct M { };

parser ParserI(packet_in pk, out H hdr, inout M meta, inout standard_metadata_t smeta) {
    state start { transition accept; }
}

control IngressI(inout H hdr, inout M meta, inout standard_metadata_t smeta) {

    apply {
        clone(CloneType.I2E, smeta.clone_spec); // this causes the error
    }

}

control EgressI(inout H hdr, inout M meta, inout standard_metadata_t smeta) {
    apply { }
}

control DeparserI(packet_out pk, in H hdr) {
    apply { }
}

control VerifyChecksumI(in H hdr, inout M meta) {
    apply { }
}

control ComputeChecksumI(inout H hdr, inout M meta) {
    apply { }
}


V1Switch(ParserI(), VerifyChecksumI(), IngressI(), EgressI(),
         ComputeChecksumI(), DeparserI()) main;

[mihaibudiu]

I have created a test case from this example. (For now this will be an XFAIL.)

[smolkaj]

I don't know if it works as expected (since I don't know what's expected), but it doesn't crash anymore.