Add libtoolize before autoreconf -i in bootstrap.sh

[junghongkao]

Such that it can avoid the following error
Running autoconf/configure tools
Unescaped left brace in regex is deprecated, passed through in regex; marked by <-- HERE in m/${ <-- HERE ([^ \t=:+{}]+)}/ at /usr/local/bin/automake line 3936.
Makefile.am:35: error: Libtool library used but 'LIBTOOL' is undefined
Makefile.am:35: The usual way to define 'LIBTOOL' is to add 'LT_INIT'
Makefile.am:35: to 'configure.ac' and run 'aclocal' and 'autoconf' again.
Makefile.am:35: If 'LT_INIT' is in 'configure.ac', make sure
Makefile.am:35: its definition is in aclocal's search path.
autoreconf: automake failed with exit status: 1

[sethfowler]

I haven't seen that error locally, and all of our tests (which build the project from scratch) are currently passing. Could you provide a bit more information about how to reproduce the error?

FWIW, LT_INIT is already called in configure.ac.

[junghongkao]

Seth, My development environment is ubuntu 16.04 with jim@onie-server:~/sdb/p4c$ autoreconf -V autoreconf (GNU Autoconf) 2.69 Copyright (C) 2012 Free Software Foundation, Inc. License GPLv3+/Autoconf: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>, <http://gnu.org/licenses/exceptions.html

This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Written by David J. MacKenzie and Akim Demaille. jim@onie-server:~/sdb/p4c$ uname -a Linux onie-server 4.4.0-59-generic #80-Ubuntu SMP Fri Jan 6 17:47:47 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Yes, LT_INIT os in configure.ac The issue shall be due to aclocal's search path in my system which can be correct through libtoolize. This could add additional coverage for some development environment. Jim

…

On Fri, Jan 27, 2017 at 9:27 AM, Seth Fowler ***@***.***> wrote: I haven't seen that error locally, and all of our tests (which build the project from scratch) are currently passing. Could you provide a bit more information about how to reproduce the error? FWIW, LT_INIT is already called in configure.ac. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#262 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ALL5MNOOH4Zne8YUR1YEMTnLiM_G8EqWks5rWikEgaJpZM4LwAiZ> .

[sethfowler]

Seems reasonable. Could you please submit a PR?

Note that libtoolize is known as glibtoolize on macOS, so you'll need to handle that case.

[junghongkao]

Seth,

Can you review the PR I have submitted ?

Jim

[ChrisDodd]

You need to make the pull request into p4lang/p4c:master