Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Bazel 8 #5065

Open
smolkaj opened this issue Dec 13, 2024 · 1 comment
Open

Upgrade to Bazel 8 #5065

smolkaj opened this issue Dec 13, 2024 · 1 comment
Labels
enhancement This topic discusses an improvement to existing compiler code. infrastructure Topics related to code style and build and test infrastructure.

Comments

@smolkaj
Copy link
Member

smolkaj commented Dec 13, 2024 •
edited
Loading

Bazel 8.0 LTS just got released: https://github.com/bazelbuild/bazel/releases/tag/8.0.0
However, we're still running on 6.4.0: https://github.com/p4lang/p4c/blob/5dc7f870f05e718a07bc935b891884eba0749395/.bazelversion

This issue tracks upgrading to Bazel 8 to fight bit rot.

I created the same issue for p4runtime and p4-constraints:
@smolkaj smolkaj mentioned this issue Dec 13, 2024
Open
@fruffy fruffy added enhancement This topic discusses an improvement to existing compiler code. infrastructure Topics related to code style and build and test infrastructure. labels Dec 13, 2024
katre added a commit to katre/p4c that referenced this issue Dec 17, 2024
@katre
Update to use Bazel 7.4.1.
e992620 
This specifically enables the legacy WORKSPACE-based resolution, and
disables the new bzlmod-based resolution.

Related to p4lang#5065 and p4lang#5066.
@katre katre mentioned this issue Dec 17, 2024
Merged
katre added a commit to katre/p4c that referenced this issue Dec 17, 2024
@katre
Update to use Bazel 7.4.1.
54e48d9 
This specifically enables the legacy WORKSPACE-based resolution, and
disables the new bzlmod-based resolution.

Related to p4lang#5065 and p4lang#5066.

Signed-off-by: John Cater <jcater@google.com>
@smolkaj
Copy link
Member Author

smolkaj commented Dec 17, 2024

Actually, we may want to give it a few months before going to 8.0 since it got just released.
In my experience, upgrading to new Bazel versions becomes much easier after a few months, when upstream dependencies like Abseil and Protobuf have led the way.

And @katre just upgraded us to 7.4.1 in #5071, so we're halfway there already :)

github-merge-queue bot pushed a commit that referenced this issue Dec 17, 2024
@katre
Update to use Bazel 7.4.1. (#5071)
6b9de96 
This specifically enables the legacy WORKSPACE-based resolution, and
disables the new bzlmod-based resolution.

Related to #5065 and #5066.

---------

Signed-off-by: John Cater <jcater@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement This topic discusses an improvement to existing compiler code. infrastructure Topics related to code style and build and test infrastructure.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fruffy @smolkaj