Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: program that accepts all legal P4_16 programs #530

Closed
jafingerhut opened this issue Apr 26, 2017 · 4 comments
Closed

Enhancement: program that accepts all legal P4_16 programs #530

jafingerhut opened this issue Apr 26, 2017 · 4 comments
Labels
enhancement This topic discusses an improvement to existing compiler code. fixed This topic is considered to be fixed.

Comments

@jafingerhut
Copy link
Contributor

p4test is pretty close to this already, but for various reasons it does not accept some syntactically and semantically legal P4_16 programs as of 2017-Apr-26, e.g. see #513

Given how close p4test is to this, one possible implementation might be to add a new p4test command line option that changes its behavior somewhat, enabling it to accept all legal P4_16 programs, e.g. --validate
@jafingerhut jafingerhut mentioned this issue Apr 26, 2017
Closed
@mihaibudiu
Copy link
Contributor

The only thing needed is to stop compilation after the front-end is finished.

@jafingerhut
Copy link
Contributor Author

jafingerhut commented Apr 26, 2017 •
edited
Loading

Sorry for my ignorance in asking, but is there already a p4test command line option (or collection of options) that achieves this, and if so, what is it?

@mihaibudiu
Copy link
Contributor

No. But that would be the fix.

@mihaibudiu mihaibudiu added the enhancement This topic discusses an improvement to existing compiler code. label Apr 27, 2017
@mihaibudiu mihaibudiu mentioned this issue May 22, 2017
Open
@jafingerhut jafingerhut mentioned this issue Jul 3, 2017
Merged
mihaibudiu pushed a commit to mihaibudiu/p4c-clone that referenced this issue Nov 9, 2017
Fix for issue p4lang#530
a3b79c7
@mihaibudiu mihaibudiu added the fixed This topic is considered to be fixed. label Nov 9, 2017
cc10512 pushed a commit that referenced this issue Nov 13, 2017
Fix for issue #530
f777694
@jafingerhut
Copy link
Contributor Author

Tested with new --validate option on the same program on issue #513 that causes p4test to issue an error, and it gives no error. Thanks!

@fefer fefer mentioned this issue Aug 7, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement This topic discusses an improvement to existing compiler code. fixed This topic is considered to be fixed.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jafingerhut @mihaibudiu