Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

P4_14 frontend should insert name annotations for bitwise-and key expressions. #539

Closed
cole-barefoot opened this issue Apr 28, 2017 · 0 comments
Closed

P4_14 frontend should insert name annotations for bitwise-and key expressions. #539

cole-barefoot opened this issue Apr 28, 2017 · 0 comments
Labels
bug This behavior is unintended and should be fixed. fixed This topic is considered to be fixed.

Comments

@cole-barefoot
Copy link
Contributor

Right now, the TableKeyNames pass extracts the name of the key operand in bitwise and key expressions when the other operand is a constant:

https://github.com/p4lang/p4c/blob/master/frontends/p4/tableKeyNames.cpp#L60

This is a P4_14 feature and should be done in the converter. See discussion here:

#528 (comment)
@mihaibudiu mihaibudiu added the bug This behavior is unintended and should be fixed. label May 1, 2017
mihaibudiu pushed a commit to mihaibudiu/p4c-clone that referenced this issue May 3, 2017
Fix for issue p4lang#539
904b172
@mihaibudiu mihaibudiu added the fixed This topic is considered to be fixed. label May 3, 2017
ChrisDodd pushed a commit that referenced this issue May 4, 2017
@ChrisDodd
Fix for issue #539 (#557)
2521d8b
@fefer fefer mentioned this issue Aug 7, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug This behavior is unintended and should be fixed. fixed This topic is considered to be fixed.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mihaibudiu @cole-barefoot