Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test in simplify.cpp seems incorrect #572

Closed
mihaibudiu opened this issue May 5, 2017 · 0 comments
Closed

Test in simplify.cpp seems incorrect #572

mihaibudiu opened this issue May 5, 2017 · 0 comments
Assignees
@mihaibudiu
Labels
fixed This topic is considered to be fixed.

Comments

@mihaibudiu
Copy link
Contributor

The following two lines are probably incorrect; they should be replaced with something like findContext<IR::P4Action>() != nullptr

bool withinAction = parent != nullptr && parent->is<IR::P4Action>();
bool withinParserState = parent != nullptr && parent->is<IR::ParserState>();
mihaibudiu pushed a commit to mihaibudiu/p4c-clone that referenced this issue May 9, 2017
Fix for issue p4lang#572
51e3c81
@mihaibudiu mihaibudiu added the fixed This topic is considered to be fixed. label May 9, 2017
@mihaibudiu mihaibudiu self-assigned this May 9, 2017
ChrisDodd pushed a commit that referenced this issue May 12, 2017
@ChrisDodd
Fix for issue #572 (#592)
01b70e8
@fefer fefer mentioned this issue Aug 7, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mihaibudiu mihaibudiu

Labels
fixed This topic is considered to be fixed.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mihaibudiu