Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect names for ingress and egress #635

Closed
mihaibudiu opened this issue May 15, 2017 · 2 comments
Closed

Incorrect names for ingress and egress #635

mihaibudiu opened this issue May 15, 2017 · 2 comments
Assignees
@hanw
Labels
bug This behavior is unintended and should be fixed. fixed This topic is considered to be fixed.

Comments

@mihaibudiu
Copy link
Contributor

The bmv2 back-end does not generate the expected names for the ingress and egress pipelines in JSON.
See #447 for an example.
@mihaibudiu mihaibudiu added the bug This behavior is unintended and should be fixed. label May 15, 2017
@hanw
Copy link
Contributor

hanw commented May 15, 2017

I have a fix for this.

hanw pushed a commit to hanw/p4c that referenced this issue May 15, 2017
fix for p4lang#635
5817511
hanw added a commit that referenced this issue May 15, 2017
@hanw
(Part 1) PSA support - addressing review comments (#618)
adcb4e6 
* address Mihai's comments
* add portableSwitch.h and simpleSwitch.h
* reorg backend to support simpleSwitch and portableSwitch
* Re-enable checksum pass
* remove mapAnnotation pass
* fix for #635
@hanw
Copy link
Contributor

hanw commented May 16, 2017

This is fixed as part of #618.

mihaibudiu pushed a commit to mihaibudiu/p4c-clone that referenced this issue May 23, 2017
Added test case to confirm that p4lang#635 is fixed
22f720c
@mihaibudiu mihaibudiu added the fixed This topic is considered to be fixed. label May 23, 2017
mihaibudiu pushed a commit that referenced this issue May 25, 2017
Added test case to confirm that #635 is fixed (#654)
0d0ebf5
@fefer fefer mentioned this issue Aug 7, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hanw hanw

Labels
bug This behavior is unintended and should be fixed. fixed This topic is considered to be fixed.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hanw @mihaibudiu