Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parser_dc_full stf test #104

Merged
merged 1 commit into from
Oct 14, 2016
Merged

Add parser_dc_full stf test #104

merged 1 commit into from
Oct 14, 2016

Conversation

ChrisDodd
Copy link
Contributor

Adding a test; experimenting with cross-repo pull requests

@ChrisDodd ChrisDodd merged commit d926f55 into p4lang:master Oct 14, 2016
@@ -57,3 +57,7 @@ XFAIL_TESTS += \
bmv2/testdata/p4_14_samples/truncate.p4.test \
bmv2/testdata/p4_16_samples/clone-bmv2.p4.test \
bmv2/testdata/p4_16_samples/drop-bmv2.p4.test

# backend bug handling current(23,1) in parser
XFAIL_TESTS += bmv2/testdata/p4_14_samples/parser_dc_full.p4.test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When trying to repro I get this:
*** Packet different at position 76 : expected 0 , received F
*** Packet 0 on port 10 differs
How did you diagnose the problem as being in current?

@ChrisDodd
Copy link
Contributor Author

I looked at the bmv2 output trace and determined the problem was that is
was failing to parse the first mpls header (which is what happens to be at
position 76 in the packet, so no suprise there). I then looked at the
generated .json file and looked at the parser state that should have been
parsing this (parse_mpls) and noticed that its key was "lookahead" with [0,
24](24 bits starting at offset 0) when it should be [23, 1](1 bit
starting at offset 23). Manually editing the json and then running
bmv2stf.py parser_dc_full.json parser_dc_full.stf works, so that would
appear to be the problem.

On Fri, Oct 14, 2016 at 2:28 PM, mbudiu-vmw notifications@github.com
wrote:

@mbudiu-vmw commented on this pull request.

In backends/bmv2/Makefile.am
#104 (review):

@@ -57,3 +57,7 @@ XFAIL_TESTS +=
bmv2/testdata/p4_14_samples/truncate.p4.test
bmv2/testdata/p4_16_samples/clone-bmv2.p4.test
bmv2/testdata/p4_16_samples/drop-bmv2.p4.test
+
+# backend bug handling current(23,1) in parser
+XFAIL_TESTS += bmv2/testdata/p4_14_samples/parser_dc_full.p4.test

When trying to repro I get this:
*** Packet different at position 76 : expected 0 , received F
*** Packet 0 on port 10 differs
How did you diagnose the problem as being in current?


You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
#104 (review), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AD4c8SoT4zBq0eQLK70dCuzImtje8vT2ks5qz_QTgaJpZM4KXURP
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants