support for varbit types #156
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisDodd
force-pushed
the
cdodd-stage
branch
from
9ee6dec
to
3840266
Compare
mihaibudiu
reviewed
Nov 29, 2016
| } else if (auto type = ftype->to<IR::Type_Varbits>()) { | ||
| auto field = pushNewArray(fields); | ||
| field->append(prefix + f->name.name); | ||
| field->append(type->size); // FIXME -- where does length go? |
There was a problem hiding this comment.
I don't think that BMv2 supports varbit types.
| @@ -131,7 +131,10 @@ bool TypeInference::done() const { | |||
| const IR::Type* TypeInference::getType(const IR::Node* element) const { | |||
| const IR::Type* result = typeMap->getType(element); | |||
| if (result == nullptr) { | |||
| typeError("Could not find type of %1%", dbp(element)); | |||
| if (auto field = element->to<IR::StructField>()) { | |||
There was a problem hiding this comment.
Fields should be in the type map.
| return vbtype; | ||
| } | ||
|
|
||
| const IR::StructField *TypeConverter::postorder(IR::StructField *field) { |
There was a problem hiding this comment.
We need a pass to do something with this annotation.
ChrisDodd
force-pushed
the
cdodd-stage
branch
from
3840266
to
b915275
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for varbit types when converting P4-14 to P4-16
I had to add a weird (I think incorrect) hack in typeChecker.cpp to make it work which I think is probably a bug elsewhere, but I'm not sure where. See the FIXME.