-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Travis & missing build dependency #1627
Conversation
The control plane now depends on the front end, so that the parser is built before the P4Runtime serializer. This fixes a heisenbug in the build process.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope this works better... Can't tell.
@mbudiu-vmw: I wasn't able to reproduce your build issue until I did a For posterity, here is the error output showing the build dependency between the control plane and the parser:
|
bison-3.1 is too new for Ubuntu 16.04.
Temporarily abusing this script as a hook to get visibility on what's going on in Travis.
Modifying `.bash_profile` isn't good enough for Travis. Have to set environment variables in `.travis.yml`.
Added missing build dependency. The control plane now depends on the front end, so that the parser is built before the P4Runtime serializer. This fixes a heisenbug in the build process.
Build now checks for
bison>=3.0.2
.Don't clobber the user's
.bash_profile
ininstall_os_deps.sh
.Fix Travis OS X job. Modifying
.bash_profile
isn't good enough for Travis. Have to setenvironment variables in
.travis.yml
.