Update instructions for installing macOS dependencies #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihaibudiu
reviewed
Dec 7, 2016
| @@ -41,7 +41,7 @@ p4c | |||
|
|
|||
| # Dependences | |||
|
|
|||
| We have tested the compiler on U*X systems (OS X and Ubuntu). The | |||
| We have tested the compiler on U*X systems (macOS and Ubuntu). The | |||
There was a problem hiding this comment.
Maybe we want to continue to support OS X too.
Not everyone wants to upgrade to the latest and greatest.
There was a problem hiding this comment.
macOS vs OS X is purely a marketing thing; there's nothing specific to a particular release here. I just figured that we may as well stay in sync with the current terminology.
cc10512
reviewed
Dec 7, 2016
| By default, Homebrew doesn't link programs into `/usr/local/bin` if they would | ||
| conflict with a version provided by the base system. This includes Bison, | ||
| since an older version ships with macOS. `make check` depends on the newer | ||
| Bison we just installed from Homebrew, so you'll want to add it to your |
There was a problem hiding this comment.
I think you should keep the explanation from above on why do we need to override the default version of bison.
+1 otherwise.
There was a problem hiding this comment.
I'll update the patch to refer to #83.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The instructions for installing dependencies on macOS are a bit out of date; Homebrew has everything that's needed now.