Fix addconfig.ac issues #186
Conversation
| @@ -20,6 +20,7 @@ set -e # exit on error | |||
| ./find-makefiles.sh # creates otherMakefiles.am, included in Makefile.am | |||
| mkdir -p extensions # place where additional back-ends are expected | |||
| echo "Running autoconf/configure tools" | |||
| rm aclocal.m4 # Needed to ensure we see updates to extension addconfig.ac files. | |||
There was a problem hiding this comment.
This should've been rm -f. I'll update the PR ASAP.
| @@ -82,7 +82,7 @@ AX_PYTHON_MODULE([re], [fatal], [python]) | |||
| dnl The following lines are just including all "addconfig.ac" files | |||
| dnl found in subdirectories | |||
|
|
|||
| m4_foreach_w([ac_file],m4_esyscmd([find -L . -name addconfig.ac 2>/dev/null]), | |||
| m4_foreach_w([ac_file],m4_esyscmd([bash -c 'find -L . -name addconfig.ac 2>/dev/null']), | |||
There was a problem hiding this comment.
Will this work on a system that does have a POSIX shell, but doesn't have bash by default (eg, OpenBSD)? I wouldn't think bash would be specifically required here, as it is just running POSIX standard find with nothing particularly tricky.
There was a problem hiding this comment.
It won't, no. I could change it to sh, but I'm not 100% sure that sh accepts -c. The sh on my system is actually bash. =)
There was a problem hiding this comment.
POSIX sh does accept -c (http://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#tag_18_01) so I think that's a better choice than bash. I would expect esyscmd to always use sh rather than the user's shell (you are using csh or some such?), as POSIX requires system(3) to use sh directly.
There was a problem hiding this comment.
Thanks; I'll switch it over to use sh. I'm actually using fish, which unfortunately esyscmd seems to insist on using by default.
|
OK, I made those changes. I'll go ahead and merge. |
This PR addresses a couple of small issues I noticed with the
addconfig.acworkflow. Changes to extensions'aclocal.m4files weren't being picked up even if you reranbootstrap.sh, and theaddconfig.acfiles were being silently ignored for users (such as myself, unfortunately) who are using non-bash-compatible shells.