Mbudiu #21
Mbudiu #21
Conversation
| @@ -3,6 +3,10 @@ | |||
|
|
|||
| namespace P4 { | |||
|
|
|||
| std::map<int, const IR::Type_Bits*> TypeMap::signedTypes; | |||
| std::map<int, const IR::Type_Bits*> TypeMap::unsignedTypes; | |||
| const IR::Type_InfInt* TypeMap::canonInfInt = new IR::Type_InfInt(); | |||
There was a problem hiding this comment.
You should never construct a Type_InfInt -- always call IR::Type::InfInt::get to get the singleton Type::InfInt object. (ctor should be private, but there's no easy way to do that through the ir generator)
Code depends on there only being one instance of this (and other) type objects.
There was a problem hiding this comment.
I just sent an email about this. This is no longer a singleton.
Mihai
From: Chris Dodd notifications@github.com
Reply-To: p4lang/p4c reply@reply.github.com
Date: Friday, April 22, 2016 at 11:11 AM
To: p4lang/p4c p4c@noreply.github.com
Cc: Mihai Budiu mbudiu@barefootnetworks.com, Author author@noreply.github.com
Subject: Re: [p4lang/p4c] Mbudiu (#21)
In frontends/common/typeMap.cpp:
@@ -3,6 +3,10 @@
namespace P4 {
+std::map<int, const IR::Type_Bits*> TypeMap::signedTypes;
+std::map<int, const IR::Type_Bits*> TypeMap::unsignedTypes;
+const IR::Type_InfInt* TypeMap::canonInfInt = new IR::Type_InfInt();
You should never construct a Type_InfInt -- always call IR::Type::InfInt::get to get the singleton Type::InfInt object. (ctor should be private, but there's no easy way to do that through the ir generator)
Code depends on there only being one instance of this (and other) type objects.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
No description provided.