Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update jsonconverter to use most recent format #223

Merged
merged 1 commit into from
Jan 10, 2017
Merged

Update jsonconverter to use most recent format #223

merged 1 commit into from
Jan 10, 2017

Conversation

antoninbas
Copy link
Member

A recent bmv2 update changes how action profile are represented in the
JSON, this commit updates the bmv2 backend accordingly.

@antoninbas
Update jsonconverter to use most recent format
65fb0bf 
A recent bmv2 update changes how action profile are represented in the
JSON, this commit updates the bmv2 backend accordingly.
@antoninbas
Copy link
Member Author

I couldn't find a P4_16 sample using the action_profile / action_selector externs defined in v1model.p4 so I added one. Hope I did it in the correct way.

ChrisDodd
ChrisDodd approved these changes Jan 10, 2017
View reviewed changes
Copy link
Contributor

@ChrisDodd ChrisDodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@antoninbas antoninbas merged commit aa520c1 into master Jan 10, 2017
@antoninbas antoninbas deleted the bmv2-json-new-act-prof-format branch January 10, 2017 16:36
@fefer fefer mentioned this pull request Aug 7, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisDodd ChrisDodd ChrisDodd approved these changes

Assignees

@ChrisDodd ChrisDodd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antoninbas @ChrisDodd