Replace BUG_CHECK with error in bmv2 backend #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisDodd
requested changes
Jan 19, 2017
There was a problem hiding this comment.
This is an unconditional error check, so it will flag an error on every verify call regardless of correctness. There are also still BUG_CHECK calls in retrieveErrorValue. It probably makes most sense to just remove this BUG_CHECK/error and change the ones in retrieveErrorValue to be if (!whatever) error(...
As requested in review for PR #234
antoninbas
force-pushed
the
bmv2-error-support
branch
from
b73d19b
to
622dbff
Compare
|
My bad, did that too fast. I fixed my commit as you suggested. However, I left the second |
mihaibudiu
approved these changes
Jan 19, 2017
ChrisDodd
approved these changes
Jan 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in review for PR #234