Turn libfrontend.a into a libtool library #244
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I added a second commit to clarify the comments in the top-level |
mihaibudiu
approved these changes
Jan 19, 2017
|
merged as 8f8b1f4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the portion of #239 that involves converting
libfrontendinto a libtool library; see that PR for the motivation.The version of this patch in #239 was cherry-picked and then backed out because it resulted in
libfrontendbeing generated as a dynamic library. It turns out that this is the default behavior for libtool libraries which are installed - that is, this is what happens by default if you uselib_LTLIBRARIES. Since this is a convenience library which is only intended to be linked into other libraries or executables, we don't want to install it, andnoinst_LTLIBRARIESis a better fit. What's nice is thatnoinst_LTLIBRARIESalso defaults to generating a static library, so this kills two birds with one stone.