Add support for enums in bmv2 backend #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting with version 2.3, the bmv2 JSON supports declaring enums. See p4lang/behavioral-model#270 for more information. The bmv2 backend was already converting enums to integers (under certain conditions). In this PR, we simply reteieve the mapping enums -> int and dump it to the JSON file. In order to do this, the ConvertEnums midend pass had to be slightly modified to give the backend access to the produced mapping.
ChrisDodd
approved these changes
Jan 20, 2017
mihaibudiu
approved these changes
Jan 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with version 2.3, the bmv2 JSON supports declaring enums. See
p4lang/behavioral-model#270 for more
information.
The bmv2 backend was already converting enums to integers (under certain
conditions). In this PR, we simply reteieve the mapping enums -> int and
dump it to the JSON file. In order to do this, the ConvertEnums midend
pass had to be slightly modified to give the backend access to the
produced mapping.