Run p4c tests that require the behavioral model in Travis #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cc10512
approved these changes
Jan 24, 2017
| @@ -19,6 +20,19 @@ RUN apt-get update && \ | |||
| python-scapy \ | |||
| tcpdump | |||
|
|
|||
| # Clone and build behavioral-model, which is needed by some tests. | |||
| ENV BEHAVIORAL_MODEL_REPO https://github.com/sethfowler/behavioral-model.git | |||
There was a problem hiding this comment.
This should be p4lang not your fork
There was a problem hiding this comment.
I should have read your explanation too. Go ahead and merge and we'll switch to main repo when Antonin merges 277.
|
@cc10512 That's actually deliberate; it won't build with the p4lang version until Antonin merges p4lang/behavioral-model#277. Would you rather wait until he does that? |
|
Sounds good. Thanks! |
sethfowler
force-pushed
the
seth/run-bmv2-tests-in-travis
branch
from
424125b
to
23d496b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Dockerfile to include the behavioral model, which enables the full suite of BMV2 tests to run on Travis.
It will be straightforward to change the repo and tag used to clone
behavior-modelfrom in the future by modifying the appropriateENVvariables. I've used my fork for the time being because I discovered some issues on thebehavioral-modelside while setting this up, but once Antonin merges p4lang/behavioral-model#277 we can switch over to his repo. (Or we can just wait and update the PR; we'll get it taken care of quickly either way.)