Use only two make jobs on Travis #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cc10512
approved these changes
Jan 24, 2017
sethfowler
force-pushed
the
seth/use-only-two-make-jobs-on-travis
branch
from
470d6c7
to
91993e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we only get two cores on Travis, it makes sense to only use two make jobs. For local builds, IMO we should still default to 8, as that will be the best choice for most developers' machines.
Note that we use
ENVto persistMAKEFLAGSin the Docker image, so theMAKEFLAGSvalue passed todocker buildwill also apply to thedocker runinvocations in.travis.yml.Before merging this, we should verify that it doesn't have a negative effect on our build times on Travis.