Work around dynamic_cast bug in clang #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihaibudiu
approved these changes
Jan 27, 2017
mihaibudiu
approved these changes
Jan 31, 2017
sethfowler
approved these changes
Feb 1, 2017
|
@ChrisDodd this is ready to go, but you'll need to rebase it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into this one trying to fix another bug. Visitor is the common (dynamic, virtual) base class of ControlFlowVisitor and Inspector, so this static_cast should be an unnecessary noop, but clang seems to have a bug in its complex inheritance handling.