Provide a directory separator if needed when converting a relative to an absolute path #293
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can't run p4c without installing it on macOS right now. The cause is that when searching for the P4 include files, on macOS we attempt to use the approach where we treat
argv[0]
as a relative path, but we don't insert a directory separator. The result is that when you run./p4c-bm2-ss
, we act as if the compiler is located at a path like/Users/sfowler/p4c/build./p4c-bm2-ss
, which is obviously wrong. This prevents us from finding the include files, and we can't compile anything. This patch solves this problem. The patch is agnostic as to whethergetcwd()
returns a path with a directory separator at the end; I'm not sure whether this is consistent across platforms.