Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allows spaces within bytes in STF scripts #322

Merged
merged 2 commits into from
Feb 23, 2017

Conversation

cc10512
Copy link
Contributor

@cc10512 cc10512 commented Feb 22, 2017

No description provided.

@cc10512 cc10512 requested a review from ChrisDodd February 22, 2017 02:16
Copy link
Contributor

@ChrisDodd ChrisDodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it breaks a couple of tests by causing the comparison of the expected packet to not match?

@cc10512
Copy link
Contributor Author

cc10512 commented Feb 22, 2017

@ChrisDodd: I'm getting a lot of failures with the current master using make check-bmv2:

============================================================================
Testsuite summary for p4c 16
============================================================================
# TOTAL: 180
# PASS:  125
# SKIP:  0
# XFAIL: 0
# FAIL:  55
# XPASS: 0
# ERROR: 0

Thoughts?

@cc10512
Copy link
Contributor Author

cc10512 commented Feb 22, 2017

@ChrisDodd, turns out that the python code handles spaces very well. The only issue that I found is the one I sent you email about with the undefined symbol for bm_runtime::standard::BmMtActProfGroup.

And then this fixes the mac version which can't seem to handle glob.glob ... go figure. With this fix, running on the mac, i get the following results:

============================================================================
Testsuite summary for p4c 16
============================================================================
# TOTAL: 553
# PASS:  499
# SKIP:  0
# XFAIL: 54
# FAIL:  0
# XPASS: 0
# ERROR: 0
============================================================================

@cc10512 cc10512 merged commit e83d11b into p4lang:master Feb 23, 2017
@cc10512 cc10512 deleted the cc/stf-spaces branch February 23, 2017 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants