Replace pna direction with register read #3224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consider statements in actions
Remove uniqued vars
mihaibudiu
requested changes
Apr 19, 2022
| @@ -96,6 +92,11 @@ p4c_add_xfail_reason("dpdk" | |||
| testdata/p4_16_samples/pna-example-mirror-packet-error3.p4 | |||
| ) | |||
|
|
|||
| p4c_add_xfail_reason("dpdk" | |||
| "declaration not found" | |||
There was a problem hiding this comment.
why is this supposed to fail with p4c-dpdk only?
There was a problem hiding this comment.
it is failing may be due to some bug in compiler frontend. I am just recording this test for fixing it later.
backends/dpdk/dpdkMetadata.cpp
Outdated
| } | ||
|
|
||
| const IR::Node* DirectionToRegRead::preorder(IR::DpdkAsmProgram *p) { | ||
| uniqueNames(p); |
backends/dpdk/dpdkMetadata.cpp
Outdated
| } | ||
| // "network_port_mask" name is used in dpdk for initialzing direction port mask | ||
| // make sure no such decls exist with that name | ||
| if (mng1.newName(registerInstanceName) != registerInstanceName) |
There was a problem hiding this comment.
Perhaps it's best if you add a new api to the name generator to check whether a name is in use.
This works too, but it is a bit ugly.
mihaibudiu
reviewed
Apr 20, 2022
| usedNames.insert(decl->name); | ||
| } | ||
|
|
||
| if (usedNames.count(registerInstanceName)) |
There was a problem hiding this comment.
This works if usedNames contains everything you need to check for. I was hoping that you'd add a new method MinimalNameGenerator::nameIsUsed(cstring name)
mihaibudiu
approved these changes
Apr 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract packet direction for PNA from an input port, By creating a Register extern network_port_mask, which will be initialized by P4SDE.
The direction metadata should be replaced by a register read from network_port_mask register and ANDing it with mask for input port
istd.direction => network_port_mask.read(0) & (32w0x1 << istd.input_port)