Fix control-plane generation for headers containing structs #3331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mihai Budiu <mbudiu@vmware.com>
|
I will amend the test to check for generic structs too. |
antoninbas
approved these changes
May 16, 2022
There was a problem hiding this comment.
You don't have to add a generic struct to the test if not needed, I realized that I was testing the wrong thing in #3329 :) Headers are always flattened, while I want to see how P4Info generation handles generic structs for things like digests. I'll write a new test.
| @@ -0,0 +1,81 @@ | |||
| /* | |||
| Copyright 2019 Cisco Systems, Inc. | |||
|
Thanks for the fix @mbudiu-vmw ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mihai Budiu mbudiu@vmware.com
Fixes #3329