Fixed start state renaming for p4-14 translation using @packet_entry #3348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The issue was that if there was a transition into the start state (for example from one of the @packet_entry states) and @packet_entry used, the compiler renamed the original start state to replace it with a new one. However these transitions into the original start state were not renamed.
mihaibudiu
requested changes
May 23, 2022
| @@ -759,6 +759,18 @@ class InsertCompilerGeneratedStartState: public Transform { | |||
| return state; | |||
| } | |||
|
|
|||
| // Rename any path refering to original start state | |||
| const IR::Node* postorder(IR::Path* path) override { | |||
There was a problem hiding this comment.
won't this also rename a variable reference if the variable is named "start"?
To be safe this should check the parent context to be a SelectCase, and moreover this to be the child #1.
There was a problem hiding this comment.
Updated to explicitly check if the path that is being changed is either within:
ParserState->selectExpression<PathExpression>->path
Or:
SelectCase->state<PathExpression>->path
mihaibudiu
approved these changes
May 24, 2022
github-sajan
pushed a commit
to github-sajan/p4c
that referenced
this pull request
May 26, 2022
…4lang#3348) * Fixed start state renaming for p4-14 translation using @packet_entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue was that if there was a transition into the start state (for example from one of the @packet_entry states) and @packet_entry used, the compiler renamed the original start state to replace it with a new one. However these transitions into the original start state were not renamed.