Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #336

Merged
merged 6 commits into from
Mar 1, 2017
Merged

Update README.md #336

merged 6 commits into from
Mar 1, 2017

Conversation

jnfoster
Copy link
Contributor

  • Clarify instructions for fetching submodules.

  • Add protobuf to list of dependencies.

  • Polish some prose.

* Clarify instructions for fetching submodules.

* Add protobuf to list of dependencies.

* Polish some prose.
@jnfoster jnfoster requested a review from cc10512 February 25, 2017 00:43
README.md Outdated
- GNU Bison and Flex (parser and lexical analyzer generators)
- GNU Bison and Flex for the parser and lexical analyzer generators.

- Google's Protocol Buffers for the control plane
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for the control plane API generation?

@@ -63,15 +69,15 @@ Most dependences can be installed using `apt-get install`:

`sudo apt-get install g++ git automake libtool libgc-dev bison flex libgmp-dev libboost-dev pkg-config python python-scapy python-ipaddr tcpdump`

An exception is Protocol Buffers; we need version 3.0, which is not available
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's mention the 3.0.2 version on the dependency list. We do put the version for Python.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@ChrisDodd ChrisDodd merged commit 4d1553a into p4lang:master Mar 1, 2017
@jnfoster jnfoster deleted the jnf-readme-fixes branch April 25, 2017 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants