Better support for header stacks in expr for bmv2 #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmv2 now supports 'stack_field' type in expressions (not just for parser transition keys). Until now the p4c bmv2 backend was assuming that this support existed, which resulted in an incorrect JSON being generated in many cases. See issue #321.
mihaibudiu
approved these changes
Feb 28, 2017
| auto version = mkArrayField(meta, "version"); | ||
| version->append(version_major); | ||
| version->append(version_minor); | ||
|
|
||
| meta->emplace("compiler", "https://github.com/p4lang/p4c"); |
There was a problem hiding this comment.
There are multiple back-ends with this url, maybe this should be p4c-bm2-ss instead.
There was a problem hiding this comment.
my reasoning is that there is only one p4c backend for bmv2; anyway this has no real use right now except providing the ability to quickly see which compiler produced the json (old one or new one)
ChrisDodd
approved these changes
Feb 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bmv2 now supports 'stack_field' type in expressions (not just for parser
transition keys). Until now the p4c bmv2 backend was assuming that this
support existed, which resulted in an incorrect JSON being generated in
many cases. See issue #321.