clean up override warning for NDEBUG builds

[ChrisDodd]

Somewhat messy way of avoiding compile time warnings for various build settings.

[cc10512]

How about the following pattern?

#ifdef NDEBUG
#define P4C_OVERRIDE_METHOD(...) __VA_ARGS__
#else
#define P4C_OVERRIDE_METHOD(...) __VA_ARGS__ = override
#endif

P4C_OVERRIDE_METHOD(void check_clone(const Visitor *));

And put the macro in a common utils.h file?

[ChrisDodd]

The macro should probably have NDEBUG in its name somewhere, since its specific to compiling with NDEBUG to disable assertion checks. Or just take out the whole thing (make the check unconditional) and don't worry about the efficiency.

[ChrisDodd]

Here's a cleaner way of getting the same effect without having to do all kinds of ifdef stuff.