Too agressive shadow warnings #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisDodd
approved these changes
Mar 8, 2017
|
I guess that this is why the diff of stderr was disabled: the preprocessor gives a different error message for the newline in string, causing the Travis test to fail. |
|
@ChrisDodd: I dont' understand why the travis build failed; this includes the fix you supplied to ignore -stderr. |
|
Actually there is a typo in the python script; I will submit a fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have also reinstated the check for the -stderr file. There are only relative paths in these files.
Since the comparison was removed we have missed several error tests which crashed the compiler; the compiler was indeed failing, but in the wrong way. There are several fixes for these crashes.